-
Notifications
You must be signed in to change notification settings - Fork 13.4k
contrib : update roles #16113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib : update roles #16113
Conversation
One thing I think could be worth considering is to encourage a minimum of 2 codeowners if at all possible in any given area. Avoids the problem of single points of failure, people going awol and generally reduces the load for any given maintainer. Only tangentially related, but recommend enabling one or two AI code review bots like sourcery-ai and gemini-code-assist, have been used with great success on RamaLama and now Docker Model Runner projects. |
Updated pull request guidelines for contributors and collaborators, and clarified merging practices for maintainers.
Hm, apparently codeowners require to have write access to the repository: https://github.com/orgs/community/discussions/23042 I was quite sure that this is not required, since we can request PR reviews from "Triage" collaborators. We can keep adding collaborators to the CODEOWNERS, but unfortunately they won't get auto-notified for PR reviews. Hopefully Github will fix this soon. |
* contrib : update roles * contrib : merge PR sections + add link to CI instructions Updated pull request guidelines for contributors and collaborators, and clarified merging practices for maintainers.
Is there a way to tell if someone's a maintainer? Right now both maintainers and Collaborators (Triage) have the collaborator sticker next to their name. |
@netrunnereve Unfortunately the Github UI does not present this information. |
* contrib : update roles * contrib : merge PR sections + add link to CI instructions Updated pull request guidelines for contributors and collaborators, and clarified merging practices for maintainers.
A few changes to the contributing guidelines regarding the roles and responsibilities of the developers. The goals are to:
After we merge this, the Github role of most existing collaborators will be updated from "Write" to "Triage". Only the core maintainers of the project will continue to have the "Write" role in the repository.